hey,

I'm still wondering how to give a bonus when a certain kiloMeter has been driven. I'm willing to give you my code below.

The only problem with this is that, it keeps on giving you money constantly, every second. I really dont know whats wrong.

Can anyone help me?

Quote from sun :

hey,

I'm still wondering how to give a bonus when a certain kiloMeter has been driven. I'm willing to give you my code below.

[SIZE=2][COLOR=#008000][SIZE=2][COLOR=#008000]
if (100 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 19155;
}
if (200 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 29000;
}
if (300 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 30000;
}
if (400 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 40000;
}
if (500 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 50000;
}
if (600 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 60000;
}
if (700 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 70000;
}
if (800 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 80000;
}
if (900 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 90000;
}
if (1000 < Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].TotalDistance / 1000)
{
Connections[GetConnIdx(Players[GetPlyIdx(MCI.Info[i].PLID)].UniqueID)].Cash += 100000;
}
[/COLOR][/SIZE][/COLOR][/SIZE]

The only problem with this is that, it keeps on giving you money constantly, every second. I really dont know whats wrong.

Can anyone help me?

it keeps on giving you money all the time because 100 < totaldistance means if there distance is bigger than 100 do that action so everytime it checks there distance its gunna just do that first action which is 100 < Totaldistance because its got no maximum Value you should do if totaldistance > 100 & totaldistance < 199.. etc that should work

Ah, thanks i'll give it a try

Quote from Robbo01 :

because its got no maximum Value you should do if totaldistance > 100 & totaldistance < 199.. etc that should work

Your reasoning is correct but your solution wrong. Yours will still give cash "every second" while in the smaller range.

One solution is to have a cash_award_level integer that you increment whenever cash is awarded. Then by checking this, you could come up with some logic to only award each cash bonus once. You could go further and use this integer to index into distance and cash award arrays, to save all the repeat code. At the very least, you'll need to reverse the order of the checks and use some else statements.

... I'm sorry... wouldn't "==" be a better operator.. cuz you want someone once they are at that distance... to have a 1 time bonus or am I on drugs?

In theory, but I'm assuming distance driven is floating point and would increment by irregular values, so chances are it would skip over an equal comparison.

I don't understand that programming language but couldnt you do something like this...


..... And So on....

Wait a minute... When I use the code, It gives me 1000 when its on 100km. and if i'm correct, it will stop at 199km. so if there was a way to only give 100 out once, Then i think it would work.

do what dawesdust_12 said then use if total distance == 100

So you mean something like this

yes try it

nope it still goes up.

Quote from sun :

nope it still goes up.

what goes up

The Money. seems its in an infinite loop.

If currentmiles > milestone
and if milestonecompleted !=true
reward, and set that milestone as done.

Don't forget to clear the milestone done, if they leave the track.

Quote from Krammeh :

and set that milestone as done.

Don't forget to clear the milestone done, if they leave the track.

Thats the kind of part I get stuck on. On my Job command, When someone types in the command to get a job, it turns a variable to true. then where the bank is I've set it so when the user goes to the bank ( part of the job ) it will give them cash. and it sets jobs = false; But it still keeps on giving them money.

Now after alot of thinking I had 2 options. One just using a new variable for example...

].KmBonus = 1);

Or i could just use what rob said. But edited.

if (totaldistance > 100 & totaldistance < 100)
{
//award bonus
}

I think i've done something like this in my later applications, when it gets to 100, it gives cash, but it cant give anymore because its supposed to stop at 100 to.

i'm not sure if I'm thinking on the right line. But I'm 67& sure that it may work.

Just a sample code from my system:


Hope i can help you

Regarts Heiko1

I might just mess with the code, get it working and post it. Not that I would use it as since when do race servers have cash?

This might be a dumb idea, but you could just keep track of what the TotalDistance was last time you checked.

you could make it like this


and so on hope this helps as i havent tried it.

@Azzano62

That won't help because it will just evaluate (player.leftpitkm >= 10000) as TRUE, every loop through after they player passes 10000(meters?)

This is the problem that SUN (OP) has in the firstplace.

yes stupid me i didnt think when i wrote it up ill make one that works then and post it later

hi i have tried to do this also with this code
but it still spams the money


been a few years since ive coded so sorry if there is a stupid error

hm.... The Km bonus Counters doesnt work on my insim ????

can any 1 help me ?

Here you go my code, simple and working. It's in my updatecheck void: