Hello everyone!

I have made a job system where it will randomly generate a location name and coordinates to a specific area.

What I have realized is, If location 1 generated a random location THAT IS THE SAME
The player can simply finish the job without moving a finger at the same place.

I added this code below
$RandomLocation = round(ToNum(RandomNum(0,13)),0)."";

Result:
But one issue again, if it generates location 1 THEN ignores it, then the player has no location to go to, and therefore the job isn't set.

Any solutions would be highly appreciated!

You should make a loop with a check if the new location isn't the same as the current location.

Make draw -> Check if number isn't same as current location ->
- If the same, draw new number, go back to check
- If not the same, procede

Not sure if I understood your full procedure but can't you just simply create a loop that reads new $RandomLocation until it differs from the current one

Quote from Yisc[NL] :

You should make a loop with a check if the new location isn't the same as the current location.

Make draw -> Check if number isn't same as current location ->
- If the same, draw new number, go back to check
- If not the same, procede

I did a loop with PrivDelayedCommand, unfortunately it doesn't work. i get no errors as well.

Better create a FOR or WHILE loop, using a variable you set to 'false' before the loop and change it to 'true' when a valid number has come up.

Quote from Yisc[NL] :

Better create a FOR or WHILE loop, using a variable you set to 'false' before the loop and change it to 'true' when a valid number has come up.

Mind giving me an example? I barely work with FOR loops and never worked on WHILE loops.

I have found a example somewhere on the lapperforum. There is not proper tutorial made for this.

But the code below, is an explaination how the Splittoarray() function works.
See if it is usefull or not.

Quote from Yisc[NL] :

Of course I don't mind
I think this example does what you want and shows how to use a WHILE-loop.


<?php 
CatchEvent OnLapperStart()
    OnLapperStart_Random_number_loop();
EndCatchEvent

CatchEvent OnMSO( $userName, $text ) # Player event
    $idxOfFirtsSpace = indexOf( $text, " ");

    IF( $idxOfFirtsSpace == -1 ) THEN
      $command = $text;
      $argv = "";
    ELSE
      $command = subStr( $text,0,$idxOfFirtsSpace );
      $argv = trim( subStr( $text,$idxOfFirtsSpace ) );
    ENDIF

    SWITCH( $command )
        CASE "!rnbr":
            Random_number_loop( $KeyFlags );
            BREAK;
    ENDSWITCH
EndCatchEvent

Sub OnLapperStart_Random_number_loop()
    ### Declare GlobalVar ####
    GlobalVar $RandomLoc;

    $RandomLoc[0] = "0";
    $RandomLoc[1] = "1";
    $RandomLoc[2] = "2";
    $RandomLoc[3] = "3";
    $RandomLoc[4] = "4";
    $RandomLoc[5] = "5";
    $RandomLoc[6] = "6";
    $RandomLoc[7] = "7";
    $RandomLoc[8] = "8";
    $RandomLoc[9] = "9";
    $RandomLoc[10] = "10";
    $RandomLoc[11] = "11";
    $RandomLoc[12] = "12";
    $RandomLoc[13] = "13";
    ### End ###
EndSub

Sub Random_number_loop( $KeyFlags )
    IF ( GetCurrentPlayerVar("CurrentJob") == "")
    THEN
      SetCurrentPlayerVar("CurrentJob", 1);
    ENDIF

    privmsg ( "^7DEBUG 1: " . GetCurrentPlayerVar("CurrentJob") );

    $valid_Loc="false";

    WHILE ($valid_Loc == "false")
        $RandomLocation = round(ToNum(RandomNum(0,13)),0)."";

        IF ( $RandomLocation != GetCurrentPlayerVar("CurrentJob") )
        THEN
          SetCurrentPlayerVar("CurrentJob", $RandomLoc[ToNum($RandomLocation)]);
          PrivMsg("^7Delivery text example to ^3" . $RandomLoc[ToNum($RandomLocation)]);
          $valid_Loc="true";
        ELSE
          privmsg ( "^7DEBUG 2: Number is the same as RandomLoc" );
        ENDIF
    ENDWHILE
EndSub
?>



You're actually a genius haha! thanks a lot, that helped!

One more thing Yisc, I realized if number is the same as randomloc it will spam $RandomLocation like 30+ times as i debugged to check which number it was generating with PrivMsg($RandomLocation) right below it.

Is this normal?

Yes, since the WHILE-loop keeps going as long as $valid_Loc is equal to "false".
There might be a better way to solve this by generating random number in one Sub, then go to other Sub for a check and back to first Sub if check fails.

Something along this line:

Quote from Yisc[NL] :

Yes, since the WHILE-loop keeps going as long as $valid_Loc is equal to "false".
There might be a better way to solve this by generating random number in one Sub, then go to other Sub for a check and back to first Sub if check fails.

Something along this line:


<?php 
Sub Random_number_loop( $KeyFlags )
    IF ( GetCurrentPlayerVar("CurrentJob") == "")
    THEN
      SetCurrentPlayerVar("CurrentJob", 1);
    ENDIF

    privmsg ( "^7DEBUG 1: " . GetCurrentPlayerVar("CurrentJob") );

    $valid_Loc="false";
    $RandomLocation = round(ToNum(RandomNum(0,13)),0)."";

    Check_number( $KeyFlags );
EndSub

Sub Check_number ( $KeyFlags )
    [ACTUAL CHECK]
    [if okay, set the playervar]
    [if not okay]
    Random_number_loop( $KeyFlags );
EndSub
?>



Thank you so much for your help! appreciate it.