In patch T3, Ive changed the way that Serbian and Croatian are detected. But there was something quite unclear and inconsistent in the Windows documentation. In Windows, they are considered to be the same language, but different sublanguages. However, the sublanguage documentation was different on the internet, and in my compiler, and there seems to be several versions of Serbian and Croatian. I am concerned that in some cases, the wrong language may be selected.

EDIT : I've repaired the reported T3 problems, in T4. So i've changed the text below, to link to T4.

The test is simple :

1) Download T4 EXE from T4 thread http://www.lfsforum.net/showthread.php?t=7234
2) Edit your cfg.txt (with notepad)
3) Delete the line starting "Lang"
4) Save cfg.txt and exit notepad
5) Run LFS

Which language is selected?

Thanks - Scawen

For me there was one error: Croatian (Bosnia and Herzegovina) caused LfS to select Serbian.

Work fine for me.
Serbian (Latin), Serbian (Cyrillic), Serbian (Cyrillic Bosnia and Herzegovina) and Serbian (Latin Bosnia and Herzegovina) - LFS select Serbian.

Everything works fine for me... Regional Settings = Croatian selects Croatian in LFS.

However, changing Regional Settings to Croatian (Bosnia and Herzegovina) selects Serbian, but it sholud select Croatian.

Serbian should be selected if the Regional Settings are one of the following: Serbian (Cyrillic), Serbian (Cyrillic, Bosnia and Herzegovina), Serbian (Latin), Serbian (Latin, Bosnia and Herzegovina).

If you use LCID GetUserDefaultLCID(void); then you should go by the codes from
http://www.microsoft.com/globa ... erence/winxp/xp-lcid.mspx
Notice that locales marked by an asterisk are new to Windows XP Service Pack 2, and will not have any effect on Windows XP without SP2 or Server 2003 - Croatian_Bosnia_Herzegovina is one of those.

For instance, GetUserDefaultLCID of 4122 (decimal) should activate the Croatian language.

Hope this clears things up a bit.

Sasa

It works just fine for Serbian.

Thanks for the tests, everyone!

ninabadrolini : thanks for the programmer advice! That was helpful - and now I understand it.

I have now fixed this in test patch T4. It looks for 4 possible Serbian sublanguages and 2 Croatian ones.

http://www.lfsforum.net/showthread.php?t=7234

Please try the test again and let me know if it works now.

Quote from Scawen :

ninabadrolini : thanks for the programmer advice! That was helpful - and now I understand it.

No problem, it appears you've nailed it in test patch T4...

Sasa

Quote from Scawen :

Please try the test again and let me know if it works now.

Croatian, Croatian (Bosnia and Herzegovina) - LFS select Croatian

Serbian (Cyrillic), Serbian (Cyrillic, Bosnia and Herzegovina), Serbian (Latin), Serbian (Latin, Bosnia and Herzegovina) - LFS select Serbian

OK!
Thanks.